Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Localization] Add localization for Teal Mask Ogerpon #4320

Closed
wants to merge 1 commit into from
Closed

[Localization] Add localization for Teal Mask Ogerpon #4320

wants to merge 1 commit into from

Conversation

Madmadness65
Copy link
Collaborator

@Madmadness65 Madmadness65 commented Sep 18, 2024 •
edited by EnochG1
Loading

What are the changes the user will see?

Ogerpon's Teal Mask form now has localized text on the starter selection screen.

Why am I making these changes?

It was overlooked before, I guess.

What are the changes from a developer perspective?

Added a localization string for ogerponTealMask in the English file. Since the other forms cannot be selected at the start, they were not included.

Screenshots/Videos

Before

image

After

image

How to test the changes?

Select Ogerpon on the starter selection screen.

Checklist

  • I'm using beta as my base branch
  • There is no overlap with another PR?
  • The PR is self-contained and cannot be split into smaller PRs?
  • Have I provided a clear explanation of the changes?
  • Have I considered writing automated tests for the issue?
  • If I have text, did I make it translatable and add a key in the English locale file(s)?
  • Have I tested the changes (manually)?
    • Are all unit tests still passing? (npm run test)
  • Are the changes visual?
    • Have I provided screenshots/videos of the changes?

@Madmadness65 Madmadness65 added Localization Provides or updates translation efforts P3 Bug Non gameplay affecting bug. typos, graphical issues, or other minor incorrect interactions. labels Sep 18, 2024
@Madmadness65 Madmadness65 requested a review from a team as a code owner September 18, 2024 23:06
EnochG1
EnochG1 reviewed Sep 19, 2024
View reviewed changes
Copy link
Contributor

@EnochG1 EnochG1 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/pagefaultgames/pokerogue/pull/3628/files#diff-5eaa21ea6be88df5a453c5a06395449e2b042d0c504b17703767e11a2a4a2df6R274
Though it is draft. Already working with all languages and other missing form names.

@Adri1
Copy link
Contributor

Adri1 commented Sep 22, 2024

Correction already part of #3628

@Adri1 Adri1 closed this Sep 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EnochG1 EnochG1 EnochG1 left review comments

@CodeTappert CodeTappert CodeTappert approved these changes

Assignees
No one assigned
Labels
Localization Provides or updates translation efforts P3 Bug Non gameplay affecting bug. typos, graphical issues, or other minor incorrect interactions.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Madmadness65 @Adri1 @EnochG1 @CodeTappert