Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QoL] Add fusion options to overrides #4298

Open
wants to merge 2 commits into
base: beta
Choose a base branch
from

Conversation

EmberCM
Copy link
Contributor

@EmberCM EmberCM commented Sep 17, 2024

What are the changes?

Create override options for starter fusions and enemy fusions

Why am I doing these changes?

Make testing easier

What did change?

Added options in the overrides.ts for fusions

export const STARTER_FUSION_OVERRIDE: boolean = false;
export const STARTER_FUSION_SPECIES_OVERRIDE: Species | integer = 0;
export const OPP_FUSION_OVERRIDE: boolean = false;
export const OPP_FUSION_SPECIES_OVERRIDE: Species | integer = 0;

Screenshots/Videos

STARTER_FUSION_OVERRIDE
starter-fusion
STARTER_FUSION_SPECIES_OVERRIDE
starter-fusion-species
OPP_FUSION_OVERRIDE
opp-fusion
OPP_FUSION_SPECIES_OVERRIDE
opp-fusion-species

How to test the changes?

Change the new options in overrides.ts

Checklist

  • There is no overlap with another PR?
  • The PR is self-contained and cannot be split into smaller PRs?
  • Have I provided a clear explanation of the changes?
  • Have I tested the changes (manually)?
    • Are all unit tests still passing? (npm run test)
  • Are the changes visual?
    • Have I provided screenshots/videos of the changes?

tests

@EmberCM EmberCM requested a review from a team as a code owner September 17, 2024 19:45
@flx-sta flx-sta added the Enhancement New feature or request label Sep 17, 2024
@flx-sta
Copy link
Collaborator

flx-sta commented Sep 17, 2024

Could you also prepare the method in overridesHelper.ts please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants