-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Qol][Mirror] Modifiers type inference v2 #4294
[Qol][Mirror] Modifiers type inference v2 #4294
Conversation
Mirror from pagefaultgames#1747 Co-authored-by: Dmitriy <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made a PR (couldn't make as suggestion because GH): flx-sta#21
Replace relative imports with absolute imports in `modifier.ts`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just marking this for later (such as if more merge conflicts happen lol).
Note
Mirror of #1747
Copied PR template/comment from #1747
What are the changes?
Add type inference to all modifier classes
Why am I doing these changes?
as Type
assertions are dangerous and this make the user experience better by adding intellisenseWhat did change?
new(...args: any[]) => SomeClass
new(...args: any[]) => SomeClass
to now useUtils.ClassType<T>
How to test the changes?
Try it out with intellisense.
Run the game in localhost to see the changes aren't breaking
Checklist
Utils.ClassType<T>
alias can be its own separate PRnpm run test
)- [ ] Are the changes visual?- [ ] Have I provided screenshots/videos of the changes?