Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Keyboard press is repeated after letting go of the key #4278

Open
wants to merge 2 commits into
base: beta
Choose a base branch
from

Conversation

podarsmarty
Copy link

@podarsmarty podarsmarty commented Sep 16, 2024

What are the changes the user will see?

  • Key press will no longer be registered and repeated when the meta key is being held down

Why am I making these changes?

  • Key presses are being input when using shortcuts on the computer accessing browser/application menus

What are the changes from a developer perspective?

  • Insuring that meta key is not held before triggering input

Screenshots/Videos

  • Hard to show in video since behavior would be the same as if I were manually holding down the key

How to test the changes?

  • Run the build and test on the main menu
  • Added unit test

Bug report

Checklist

  • I'm using beta as my base branch
  • There is no overlap with another PR?
  • The PR is self-contained and cannot be split into smaller PRs?
  • Have I provided a clear explanation of the changes?
  • Have I considered writing automated tests for the issue?
  • If I have text, did I make it translatable and add a key in the English locale file(s)?
  • Have I tested the changes (manually)?
    • Are all unit tests still passing? (npm run test)
  • Are the changes visual?
    • Have I provided screenshots/videos of the changes?

@podarsmarty podarsmarty marked this pull request as ready for review September 16, 2024 05:33
@podarsmarty podarsmarty requested a review from a team as a code owner September 16, 2024 05:33
@f-fsantos
Copy link
Collaborator

#1288 Please review all the known cases and make sure your fix covers all of them.

@flx-sta flx-sta linked an issue Sep 16, 2024 that may be closed by this pull request
@podarsmarty
Copy link
Author

podarsmarty commented Sep 16, 2024

@f-fsantos i think that one is different? repeated inputs without mention of modifiers being pressed. i cant repro it to begin with so cant confirm/deny if this pr changes anything with it

only way i can get it to repro the behavior in the linked ticket is by holding command and shift while inputting directions. this pr will in fact fix that issue

@flx-sta flx-sta added the P2 Bug Minor. Non crashing Incorrect move/ability/interaction label Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 Bug Minor. Non crashing Incorrect move/ability/interaction
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Repeated phantom inputs
3 participants