Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Localization] Hebrew Inital commit #4272

Draft
wants to merge 35 commits into
base: beta
Choose a base branch
from
Draft

Conversation

Adri1
Copy link
Contributor

@Adri1 Adri1 commented Sep 15, 2024

PR made on behalf of the Hebrew-speaking translator

What are the changes the user will see?

Now translatable into Hebrew

Why am I making these changes?

To make the game available in Hebrew

What are the changes from a developer perspective?

One more language to consider

Screenshots/Videos

image

How to test the changes?

Game Settings, and set the game in Hebrew

Checklist

  • I'm using beta as my base branch
  • There is no overlap with another PR?
  • The PR is self-contained and cannot be split into smaller PRs?
  • Have I provided a clear explanation of the changes?
  • Have I tested the changes (manually)?
    • Are all unit tests still passing? (npm run test)
  • Are the changes visual?
    • Have I provided screenshots/videos of the changes?

@Adri1 Adri1 added the Localization Provides or updates translation efforts label Sep 15, 2024
@Adri1 Adri1 requested review from a team as code owners September 15, 2024 19:19
@Adri1 Adri1 marked this pull request as draft September 15, 2024 19:20
@CodeTappert
Copy link
Collaborator

Please change it to he

Since there is no other subdivision for hebrew

@flx-sta
Copy link
Collaborator

flx-sta commented Sep 18, 2024

@Adri1 please make sure to empty the json-files (meaning to leave only a {} inside (see "catalan").
Otherwise it brings it back to the issue with having fake translations in there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Localization Provides or updates translation efforts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants