[Bug] Dragon Tail now properly respects abilities like Suction Cups #4252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DayKev
added
Move
|
Btw you can use https://github.com/pagefaultgames/pokerogue/pull/4252/files?diff=unified&w=1 to have GitHub show the diff while ignoring whitespace-only changes. |
DayKev
force-pushed
the
fix-dragon-tail
branch
from
84f5352
to
3cc560a
Compare
DayKev
force-pushed
the
fix-dragon-tail
branch
2 times, most recently
from
9dd2178
to
86358c8
Compare
DayKev
force-pushed
the
fix-dragon-tail
branch
from
86358c8
to
93b334c
Compare
|
There's some overlap with #4382 here, as that includes a major rewrite of |
|
The only change you made to |
innerthunder
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes the user will see?
Moves like Dragon Tail now more accurately respect abilities like Suction Cups.
Why am I making these changes?
Came across a bug in unrelated testing and ran into this massive bunch of 🍝.
What are the changes from a developer perspective?
Moves with
ForceSwitchOutAttrproperly parse the target's abilities to see if they should switch out the target.Additional tests added for Dragon Tail.
Also fixed the indentation while I was here.
How to test the changes?
npm run test dragon_tailChecklist
betaas my base branch[ ] If I have text, did I make it translatable and add a key in the English locale file(s)?npm run test)[ ] Are the changes visual?[ ] Have I provided screenshots/videos of the changes?