-
Notifications
You must be signed in to change notification settings - Fork 143
chore(examples): add protobuf example #1089
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Add a new example showcasing how to use the Protobuf plugin to validate Protobuf over HTTP content. Signed-off-by: JP-Ellis <[email protected]>
Signed-off-by: JP-Ellis <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1089 +/- ##
====================================
Coverage 78% 78%
====================================
Files 31 31
Lines 3683 3683
====================================
+ Hits 2890 2896 +6
+ Misses 793 787 -6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That example was very clear to me, nicely done. The comments are likely to be very helpful for a newbie.
The DSL looks sensible also, and presumably Python idiomatic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, comment about adding parameterised provider states, but other than that 👌🏾 from me. code docs are useful for context
📝 Summary
Add a new example showcasing how to use the Protobuf plugin to validate Protobuf over HTTP content.
This first example is crude and does not yet do any content matching. This will be done in a follow up PR.
🚨 Breaking Changes🔥 Motivation
Plugins are not very easy to use, and the
v3
API is still very new. This should hopefully help with adoption of V3 and help end-users of Pact Python adopt the tool.🔨 Test Plan
All examples are tested as part of CI.
🔗 Related issues/PRs