Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix 'Exception: String could not be parsed as XML' in xml's consumer test #624

Merged
merged 1 commit into from
Aug 30, 2024
Merged

fix: Fix 'Exception: String could not be parsed as XML' in xml's consumer test #624

merged 1 commit into from
Aug 30, 2024

Conversation

tienvx
Copy link
Contributor

@tienvx tienvx commented Aug 29, 2024 •
edited
Loading

The reason is:

->setBody(
    json_encode($xmlBuilder)
);

This code set body's content type to text/plain. I need to set the content type to the correct one (application/xml)

cc @JP-Ellis

Link to related issue/comment:

@tienvx tienvx requested a review from YOU54F August 29, 2024 18:29
@coveralls
Copy link

Pull Request Test Coverage Report for Build 10620636332

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.313%
Totals Coverage Status
Change from base Build 10620508147: 0.0%
Covered Lines: 2282
Relevant Lines: 2345
💛 - Coveralls

@tienvx tienvx merged commit 55e5d60 into pact-foundation:master Aug 30, 2024
28 of 29 checks passed
@tienvx tienvx deleted the fix-string-could-not-be-parsed-as-xml branch August 30, 2024 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JP-Ellis JP-Ellis JP-Ellis approved these changes

@YOU54F YOU54F Awaiting requested review from YOU54F

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tienvx @coveralls @JP-Ellis