-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add docs for build in-obs #897
base: main
Are you sure you want to change the base?
Conversation
Build succeeded. ✔️ pre-commit SUCCESS in 1m 29s |
Build succeeded. ✔️ pre-commit SUCCESS in 1m 05s |
Build succeeded. ✔️ pre-commit SUCCESS in 1m 13s |
|
||
* SPEC file for the project placed in the repository. | ||
* Packit config file placed in the repository. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We definitely have to mention here that the user must have osc configured. Otherwise nothing in here will work.
Build succeeded. ✔️ pre-commit SUCCESS in 1m 23s |
docs/cli/build/in-obs.md
Outdated
$ packit build in-obs --project <project_name> | ||
``` | ||
|
||
## Help |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure if you know this, but this is being regenerated automatically from the real help message so you don't need to take care of updating.. Also, what you put into the help message can be edited in one place (~ packit
project) and is then visible both in the help message and on docs...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The script is here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay so the help section is updated automatically
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we leave the other sections in?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, yes!
Build succeeded. ✔️ pre-commit SUCCESS in 1m 13s |
fb3eb7c
to
e2e1628
Compare
Build succeeded. ✔️ pre-commit SUCCESS in 1m 12s |
@rxbryan can you please rebase this pull-request? (Or, should I take care of it?) |
Build succeeded. ✔️ pre-commit SUCCESS in 1m 17s |
Done. I have also marked the PR ready for review |
Add docs for
packit build in-obs