Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document pre-releases #777

Merged
merged 1 commit into from
Nov 21, 2023
Merged

Conversation

nforro
Copy link
Member

@nforro nforro commented Nov 20, 2023

No description provided.

@nforro nforro mentioned this pull request Nov 20, 2023
Copy link
Contributor

Copy link
Member

@lbarcziova lbarcziova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM 👍

%autosetup -p1 -n %{name}-%{upstream_version}
```

Packit supports both ways. There is a config option `prerelease_suffix_pattern` that defines a regex that is used to determine if a version is a pre-release or not. It defaults to `([.\-_~^]?)(alpha|beta|rc|pre(view)?)([.\-_]?\d+)?` and you can adjust it if your project uses a different versioning scheme or undefine it to opt-out from pre-release processing. The first capturing group of the regex should capture the delimiter and can be empty if there is none.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you please also add the options to the configuration docs and link it from here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, I hope I didn't mess up the links.

Signed-off-by: Nikola Forró <[email protected]>
Copy link
Contributor

Copy link
Member

@lbarcziova lbarcziova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nicelly done!

@nforro nforro added the mergeit When set, zuul wil gate and merge the PR. label Nov 21, 2023
Copy link
Contributor

Build succeeded (gate pipeline).
https://softwarefactory-project.io/zuul/t/packit-service/buildset/ffd277a339bf471fba4e7f3e822e8a86

✔️ pre-commit SUCCESS in 1m 10s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit dfedd63 into packit:main Nov 21, 2023
1 check passed
@nforro nforro deleted the prerelease branch November 21, 2023 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mergeit When set, zuul wil gate and merge the PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants