Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: every release note text being changed #15

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Venefilyn
Copy link

@Venefilyn Venefilyn commented Mar 29, 2024

Changes the

RELEASE NOTES BEGIN

Packit now supports automatic ordering of ☕ after all checks pass.

RELEASE NOTES END

to

RELEASE NOTES BEGIN

RELEASE NOTES END

@Venefilyn Venefilyn changed the title fix: revery release note text being changed fix: every release note text being changed Apr 7, 2024
Copy link
Member

@lbarcziova lbarcziova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was meant as a showcase of a release note format that should be replaced/removed by an actual change, but I see it might be not clear for outside contributors, so maybe we could just adjust it to something like

<replace the following or put N/A here>
Packit now supports automatic ordering of ☕ after all checks pass.

Copy link
Member

@mfocko mfocko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change will also require the default in https://github.com/packit/.github/blob/main/.github/workflows/check-release-notes.yml to be changed…

@Venefilyn
Copy link
Author

Gotcha, yeah it felt like a mistake to me as it wasn't made clear to be an example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants