feat: fix parsing of names and namespaces with colons #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This attempts to comply with the specification. Closes package-url#152 (I think) See discussion at package-url#152 Signed-off-by: Joshua Kugler <[email protected]>
|
Howdy @tdruez, could you have a look? Thanks! |
|
@jkugler Thanks. You may want to run |
pombredanne
requested changes
Feb 9, 2025
|
|
||
| assert p.type == "nuget" | ||
| assert p.namespace is None | ||
| assert p.name == "libiconv: character set conversion library" |
There was a problem hiding this comment.
Is this a real name, seen in the wild? I do not think this would be a valid NuGet name.
|
|
||
| def test_colons_in_namespace_are_handled_correctly() -> None: | ||
| p = PackageURL.from_string( | ||
| "pkg:nuget/an:odd:space/libiconv:%20character%20set%20conversion%[email protected]?package-id=e11a609df352e292" |
There was a problem hiding this comment.
Could you use actual real life data rather than made up ones? In all cases the colon should be encoded there IMHO.
| @@ -459,12 +467,17 @@ def from_string(cls, purl: str) -> Self: | |||
| url=remainder, scheme="", allow_fragments=True | |||
| ) | |||
|
|
|||
| if scheme or authority: | |||
There was a problem hiding this comment.
This would be a serious API change, why do you remove this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This attempts to comply with the specification; at minimum brings it in line with what all the other libraries do.
Closes #152
(I think)
See comment at #152 (comment)