Better Multithreading #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Earthcomputer
requested changes
Apr 14, 2020
stylefix 1
stylefix 2
stylefix 3
stylefix 4
|
styling should be corrected now. |
compile error fixes
Removed unnecessary heap allocation
Unfortunately this may or may not be faster due to icache, testing is required to verify.
Minimal performance hit.
riking
reviewed
Apr 15, 2020
main.cu
Outdated
| static auto threadFunc = [&](size_t start, size_t end) { | ||
| for (int j = start; j < end; ++j) { | ||
| if (generator::ChunkGenerator::populate(tempStorage[j], X_TRANSLATE + 16)) { | ||
| std::lock_guard<std::mutex> lock(fileMutex); |
There was a problem hiding this comment.
This looks like it's going to have a heck of a lot of mutex contention. Could the threads batch up their file writes?
Optimizations
Also, use the PRIu64 macro to fix the printf format debacle once and for all
[Major] Use wall clock time for progress reports
…t-pr Revert "Multithreading + file write optimizations"
stylefix 1
stylefix 2
stylefix 3
stylefix 4
compile error fixes
about 7% performance boost on my maschine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code styling got a bit fucked because of my settings.