-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a dropdown to select CMIP version #72
Conversation
Feedback from Stephen:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Coming along nicely! Some comments to do with layout and code style, but no functional changes to suggest.
I'll reply as I can to the feedback items from Stephen.
It does "do something", but our data is such that it has it nil effect. Okay, confusing. The selector allows to select for locations that definitely have the specified time period. (As opposed to locations with any time period available, i.e., no filtering. So come to think of it, "Any" would be a much better label than "All".) Because every location has every time period (it appears), the selector doesn't have any perceptible effect. It may not have much use if this is always true; we should consult with Stephen about that.
What does that mean? If he's talking about the table of files that shows when you click show, you can click on any column header to sort table by that value. That makes it "sequential" in some sense.
Yes, click on Time Period column, then on the Scenario Column. What he might prefer is to have the default sort set up this way. That is easy if it is the requirement. Right now it is either not set at all or is the Type column. |
I believe Stephen would like the decades in the rows under the "Time Periods" column to be ordered so it's easier to tell at a glance which ones are present. I am going to look into whether this is easy; if not it can be a separate issue.
I'll see if I can set the default to be scenario for the inner files table. |
Made suggested code improvements. Addressed two of Stephen's requests:
Demo has been updated. |
Looks great so far. |
Adds a dropdown to switch between CMIP5 and CMIP6 data. The switch is performed by filtering location data before it is passed to the table.
Demo.
Resolves #71