-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MBCn Climatologies #464
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Clicked around the demo a little, things seemed to work. Had a couple questions on the help update.
Is the data suppose to be the somewhat weird shape of "all pcanada, plus a chunk of the US"?
|
||
* **`rp5pr`** | ||
* **`rp5pr`** / **`rl5pr`** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is rather confusing (but maybe not something we can do anything about) the lowercase L looks rather like a number 1, especially in the typewriter font used on the help page. It's at least clearer on the app, which says "RL30 for mazimal annual precipitation".
I don't have any ideas, but is there something we could do to make it less confusing in the help? I dunno, explain what RL stands for or something?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The description for these variables above says that it's "return period/level", but I could change it to something like "return period/level (rp for CMIP5 and rl for CMIP6 respectively)". Or we could make these variables uppercase, but that may look awkward since the other variables are lowercase in the help.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That might help a little, seems worth a shot.
* **`rl30tasmin`** | ||
|
||
30-year annual minimum daily minimum temperature | ||
|
||
* **`rp50tasmin`** | ||
|
||
50-year annual minimum daily minimum temperature |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you fix the "atreamflow" typo about fifty lines down, while you're at it?
export const findScenarioIncluding = (s) => (options) => | ||
find((opt) => opt.value.representative.experiment.includes(s))(options) || | ||
fallback(options); | ||
export const findScenarioIncluding = (scenarios) => (options) => |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, good way to handle this.
Yeah, the MBCn data is supposed to have that chunk of the US. |
LGTM, Eric! |
This PR resolves #456 and contains the minimal changes for displaying the new climatologies with the SSP 5-8.5 scenario as the default. It also updates the public documentation to describe the new climatologies.
Demo available at https://services.pacificclimate.org/dev/pcex/app/#/data/climo/ce_cmip6_mbcn