Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MBCn Climatologies #464

Merged
merged 7 commits into from
Jun 11, 2024
Merged

Add MBCn Climatologies #464

merged 7 commits into from
Jun 11, 2024

Conversation

eyvorchuk
Copy link
Contributor

@eyvorchuk eyvorchuk commented Jun 3, 2024

This PR resolves #456 and contains the minimal changes for displaying the new climatologies with the SSP 5-8.5 scenario as the default. It also updates the public documentation to describe the new climatologies.

Demo available at https://services.pacificclimate.org/dev/pcex/app/#/data/climo/ce_cmip6_mbcn

@eyvorchuk eyvorchuk requested review from QSparks and corviday June 3, 2024 20:01
Copy link
Contributor

@corviday corviday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Clicked around the demo a little, things seemed to work. Had a couple questions on the help update.

Is the data suppose to be the somewhat weird shape of "all pcanada, plus a chunk of the US"?


* **`rp5pr`**
* **`rp5pr`** / **`rl5pr`**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is rather confusing (but maybe not something we can do anything about) the lowercase L looks rather like a number 1, especially in the typewriter font used on the help page. It's at least clearer on the app, which says "RL30 for mazimal annual precipitation".

I don't have any ideas, but is there something we could do to make it less confusing in the help? I dunno, explain what RL stands for or something?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The description for these variables above says that it's "return period/level", but I could change it to something like "return period/level (rp for CMIP5 and rl for CMIP6 respectively)". Or we could make these variables uppercase, but that may look awkward since the other variables are lowercase in the help.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That might help a little, seems worth a shot.

* **`rl30tasmin`**

30-year annual minimum daily minimum temperature

* **`rp50tasmin`**

50-year annual minimum daily minimum temperature
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you fix the "atreamflow" typo about fifty lines down, while you're at it?

export const findScenarioIncluding = (s) => (options) =>
find((opt) => opt.value.representative.experiment.includes(s))(options) ||
fallback(options);
export const findScenarioIncluding = (scenarios) => (options) =>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, good way to handle this.

@eyvorchuk
Copy link
Contributor Author

Is the data suppose to be the somewhat weird shape of "all pcanada, plus a chunk of the US"?

Yeah, the MBCn data is supposed to have that chunk of the US.

@QSparks
Copy link

QSparks commented Jun 5, 2024

LGTM, Eric!
I have one small suggestion to add the CMIP6 Terms of Use to the About section of the public docs.

@eyvorchuk eyvorchuk merged commit f0a2ea1 into master Jun 11, 2024
3 checks passed
@eyvorchuk eyvorchuk deleted the mbcn-climatologies branch June 11, 2024 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace CMIP6 BCCAQv2 Climatologies with MBCn Climatologies
3 participants