Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vNext #148

Merged
merged 38 commits into from
Apr 18, 2024
Merged

vNext #148

merged 38 commits into from
Apr 18, 2024

Conversation

pachi81
Copy link
Owner

@pachi81 pachi81 commented Apr 11, 2024

Bugfixes for current version

@pachi81
Copy link
Owner Author

pachi81 commented Apr 11, 2024

@froster82 @dinizmauricio
I have to create a new version with some bugfixes, as my changes on the alarms will take some time...
Can you please update your language file for the parts at the bottom under new.
Thank you!

@froster82
Copy link
Collaborator

@pachi81, I will deal with it as soon as I can. Tomorrow, I have a lot on ny plate, but will do my best.

@pachi81
Copy link
Owner Author

pachi81 commented Apr 11, 2024

@froster82 No problem!

Translated, updated and corrected some previous strings.
Copy link
Collaborator

@froster82 froster82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Polish part done.

@pachi81
Copy link
Owner Author

pachi81 commented Apr 14, 2024

@froster82 @dinizmauricio
The new version is online for testing. Please check, if everything is fine.
@dinizmauricio I granted you access to this repo, so you can change the strings directly in this commit.
Please provide feedback, even if everything is fine for you.
Thank you!

@froster82
Copy link
Collaborator

@pachi81 app seems to work ok, but there is a bug with lockscreen wallpaper. The option itself works fine, but when I turned it off, the phone restored not my previous wallpaper (the one I used to hqve before switching on the option in GDH, but the default wallpaper and lockscreen wallpaper the phone had in the beginning of its use.
Also the message in the app says press here to go directly to nitification settings. When I press, nothing happens.
See screens.
Screenshot_20240414-195747_GlucoDataHandler
Screenshot_20240414-195940_GlucoDataHandler
Screenshot_20240414-200006_One UI Home

@dinizmauricio
Copy link
Collaborator

Is there a compiled apk version? Is it on the Google Play store? It didn't appear to me.

@froster82
Copy link
Collaborator

@dinizmauricio, hi! Check your Google Play and GDH there. You should have info that this is a beta version for internal testing. If so, you should have an update to download.

Adjusted small detail in a String
@dinizmauricio
Copy link
Collaborator

phone
wear

I just tested today's version, I didn't find the errors previously reported :)
I still don't understand what I should do to make the wear work :/

Polish strings done.
@pachi81
Copy link
Owner Author

pachi81 commented Apr 15, 2024

I still don't understand what I should do to make the wear work :/

@dinizmauricio For any reason, the first connection sometimes have problems.
Please try to touch on wear on "Phone: disconnected" and on phone und the related label (it will re-check connection in the background).
If it does not work, please restart watch.

@pachi81
Copy link
Owner Author

pachi81 commented Apr 15, 2024

@froster82 @dinizmauricio Thank you for your fast translation! New version is online.

@froster82
Copy link
Collaborator

@pachi81 lockscreen walpaper bug after turning off the option in GDH is still present on my phone. Last time both wallpapers were restored to factory defaults. Now only the lockscreen wallpaper is chcnged to default, but the normal screen gets back to my usual wallpaper.

@pachi81
Copy link
Owner Author

pachi81 commented Apr 15, 2024

@pachi81 lockscreen walpaper bug after turning off the option in GDH is still present on my phone. Last time both wallpapers were restored to factory defaults. Now only the lockscreen wallpaper is chcnged to default, but the normal screen gets back to my usual wallpaper.

@froster82 this behavior depends on the phone and I can not change it. I only changed, resetting the normal wallpaper.
I think this behavior is the normal one, as you normally has to set a new wallpaper, if you want change it. So I can only unset the current one, so you will get a black screen.

@froster82
Copy link
Collaborator

Ok, no worries. Just wanted to let you know that this might happen.
I changed the Polish translation for rate in string 8. I had some questions about it, but was not sure how to correct it. Now I checked the German string and trend in Polish will also be better.

@froster82
Copy link
Collaborator

@pachi81, I found another bug, which was not present previously.
Widget on the main screen is not refreshed properly, when no current value arrives. It used to be greyed out and crossed out automatically.
My circumstances: my source is my watch. I have a widget on the phone. During the night watch is put to sleep mode, so the GDH broadcast is silenced. The phone does not receive data and greys out the widget. Today the widget got stuck on the last value it received and was green all the time. I retested it - went with the watch out of phone reach and when I came back widget was also stuck. The app itself however shows everything ok - crossed out value.
A newly introduced widget swows everything ok.
Pasting screens below.

Screenshot_20240416-065144_One UI Home
Screenshot_20240416-065203_GlucoDataHandler
Screenshot_20240416-065233_One UI Home
Screenshot_20240416-073608_One UI Home
Screenshot_20240416-073624_GlucoDataHandler

@pachi81
Copy link
Owner Author

pachi81 commented Apr 16, 2024

A newly introduced widget swows everything ok. Pasting screens below.

@froster82 the new widget is working correct? So it may happen, that during an upgrade, the widget connection gets lost. Also the notification connection may get lost. I have no idea, why this is happen sometime. In this situations, you have to restart you phone or re-add the widget.
If it happened again, please send me the logs.

@froster82
Copy link
Collaborator

@pachi81, when the connection is restored, the widget is refreshed again and later shows everything fine. But it is not greyed out and crossed out when it is out of reach of the source. No need to restart the phone or add new widget. As if the sole picture of the crossed out value is not sent to the widget when it loses the connection.

@pachi81
Copy link
Owner Author

pachi81 commented Apr 16, 2024

@pachi81, when the connection is restored, the widget is refreshed again and later shows everything fine. But it is not greyed out and crossed out when it is out of reach of the source. No need to restart the phone or add new widget. As if the sole picture of the crossed out value is not sent to the widget when it loses the connection.

@froster82 Now, I understand. Yes, I have tested. You are right! I´m using the widget with timestamp and this seems to be working. But the one without, is not working. I will check and fix. Thank you!

@pachi81
Copy link
Owner Author

pachi81 commented Apr 16, 2024

@froster82 fix is online.

I fine tuned some strings in context.
@froster82
Copy link
Collaborator

@pachi81, I had a chance to test the widget bug. When the value and trend are greyed out and crossed in the app, they are not on the widget. When the app completely loses the value and trend, the widget also loses its stuck values. A bit strange. Again, when the connection is resumed, everything comes back to normal.
Screenshot_20240417-172059_GlucoDataHandler
Screenshot_20240417-172109_One UI Home

@pachi81
Copy link
Owner Author

pachi81 commented Apr 17, 2024

@froster82 this happens with the latest version? Please send me the logs, if it happened!
Thank you!

@froster82
Copy link
Collaborator

@pachi81, yes this was today. I sent the log to your email address.

@froster82
Copy link
Collaborator

@pachi81, now I turned off bluetooth completely in the phone, waitwd for about 5 minutes and... the app and thr widget got grey and crossed out. Now it works all as it should. Will try to replicate my previous behaviour and circumstances tomorrow, but it seem everything ia ok.
Sorry for false alarm.

@pachi81
Copy link
Owner Author

pachi81 commented Apr 18, 2024

@pachi81, now I turned off bluetooth completely in the phone, waitwd for about 5 minutes and... the app and thr widget got grey and crossed out. Now it works all as it should. Will try to replicate my previous behaviour and circumstances tomorrow, but it seem everything ia ok. Sorry for false alarm.

@froster82 Not sure, if it was really false alarm, but I hope 😉
Please have a look from time to time on widget and notification and if it happens again, send me the logs.
Thank you very much for your testing!

@froster82
Copy link
Collaborator

Ok, not a false alarm ;/
I described everything in the email with screens and logs.

@pachi81 pachi81 merged commit d6cc2d9 into master Apr 18, 2024
@pachi81 pachi81 deleted the vNext branch April 18, 2024 18:43
This was linked to issues Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Brazilian Portuguese translations Size of text on lock screen
3 participants