Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix possibly improper map list #6

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sneak-it
Copy link

@sneak-it sneak-it commented Sep 14, 2019

The drop-down menu with the map list could possibly be "incorrect". As it currently stands, this list is grabbed by a query which gets every distinct map name found in the mapzones table, and puts them in alphabetical order.

This is problematic for 2 reasons:

  • Automatically zoned maps (trigger starts/ends) do not get inserted to the mapzones table, meaning you will need to manipulate the URL to get to these maps and see their stats.
  • It is more likely that servers will have "extra" zoned maps (maps that are probably not even on server), and lead to blank stats pages.

This solves both above issues by changing the query to the playertimes table. This way, only maps that have completions on the map/bonus get listed. Hat tip to @mbhound for identifying the issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant