Skip to content

Commit

Permalink
chore: Make Nodejs20 default runtime (kyma-project#2006)
Browse files Browse the repository at this point in the history
* chore: Make Nodejs20 default runtime

* use non-default runtime in tests
  • Loading branch information
halamix2 authored and pPrecel committed May 20, 2024
1 parent 0a543e1 commit 2ebfebd
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion cmd/kyma/init/function/function.go
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ import (
)

const (
defaultRuntime = "nodejs18"
defaultRuntime = "nodejs20"
defaultReference = "main"
defaultBaseDir = "/"
)
Expand Down
2 changes: 1 addition & 1 deletion cmd/kyma/init/function/function_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ func TestFunctionFlags(t *testing.T) {
require.Equal(t, "", o.Name, "Default value for the --name flag not as expected.")
require.Equal(t, "", o.Namespace, "Default value for the --namespace flag not as expected.")
require.Equal(t, "", o.Dir, "Default value for the --dir flag not as expected.")
require.Equal(t, "nodejs18", o.Runtime, "Default value for the --runtime flag not as expected.")
require.Equal(t, "nodejs20", o.Runtime, "Default value for the --runtime flag not as expected.")
require.Equal(t, "", o.RuntimeImageOverride, "The parsed value for the --runtime-image-override flag not as expected.")
require.Equal(t, "", o.URL, "The parsed value for the --url flag not as expected.")
require.Equal(t, "", o.RepositoryName, "The parsed value for the --repository-name flag not as expected.")
Expand Down
2 changes: 1 addition & 1 deletion docs/gen-docs/kyma_init_function.md
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ kyma init function [flags]
- nodejs18 (deprecated)
- nodejs20
- python39 (deprecated)
- python312 (default "nodejs18")
- python312 (default "nodejs20")
--runtime-image-override string Set custom runtime image base.
--schema-version string Version of the config API. (default "v0")
--url string Git repository URL
Expand Down

0 comments on commit 2ebfebd

Please sign in to comment.