Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure pre-commit to run black, flake8, and Isort before commits. #460

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

AdityyaX
Copy link

@AdityyaX AdityyaX commented Dec 5, 2023

#452

Hi @tushar5526 sir,

I've just submitted a pull request that aims to set up pre-commit to run black, flake8,isort before commits I would greatly appreciate it if you could take some time to review it.

Details:

  • Black: : code formatter
  • Flake8: Checks Python code against standards
  • Isort: Organizes and sorts import statements

Changes done:

  • Points for Review: .pre-commit-config.yaml file added
Screenshot 2023-12-05 at 1 09 56 PM

Expected Behaviour:

Screen.Recording.2023-12-05.at.12.56.42.PM.mov

Your suggestions and feedback would be extremely beneficial in ensuring the quality and functioning of these update

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing to p5py

@AdityyaX AdityyaX changed the title Configure pre-commit to run black, flake8, and Isort before commits. Configure pre-commit to run black, flake8, and Isort before commits. Dec 5, 2023
@tushar5526
Copy link
Member

Hey @AdityyaX, no need to refer to me as sir here 😅

Can you make this part of GitHub CI?

I believe we would have to solve the flake8 errors as well. It is a hard problem - you can make a different PR or make it part of this one.

@AdityyaX
Copy link
Author

AdityyaX commented Dec 6, 2023

@tushar5526 Absolutely, I'll do my best to assist you with it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants