Add 'const' qualifier to bf_sys_log parameters #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Declared the parameters to bf_sys_log_init() to be const pointers, so you can pass a literal string to them without getting compile errors. Did the same for several other functions that aren't part of the external interface. Signed-off-by: Derek G Foster <[email protected]>
fruffy
approved these changes
Apr 29, 2024
saynb
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Declared the parameters to bf_sys_log_init() to be const pointers, so you can pass a literal string to them without getting compile errors. (Plus, it's good programming practice to declare all input pointer parameters as pointers to const, making their values explicitly immutable.)
Did the same for several other functions that aren't part of the external interface.