Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove license symlink to resolve build issues. #488

Merged
merged 1 commit into from
Jul 24, 2024
Merged

Remove license symlink to resolve build issues. #488

merged 1 commit into from
Jul 24, 2024

Conversation

jonathan-dilorenzo
Copy link
Contributor

We're running into build issues due to the symlink and some interaction with zip files. Since the original LICENSE file last changed 6 years ago, I figure we might be OK with the duplication instead of the sym link?

Previous error:

/home/runner/.cache/bazel/_bazel_runner/edc9951cbd41acd2e30f113cd8beddfe/external/bazel_tools/tools/build_defs/repo/http.bzl:372:31: in <toplevel>
ERROR: An error occurred during the fetch of repository 'com_github_p4lang_p4runtime':
   Traceback (most recent call last):
	File "/home/runner/.cache/bazel/_bazel_runner/edc9951cbd41acd2e30f113cd8beddfe/external/bazel_tools/tools/build_defs/repo/http.bzl", line 132, column 45, in _http_archive_impl
		download_info = ctx.download_and_extract(
Error in download_and_extract: java.io.IOException: Error extracting /home/runner/.cache/bazel/_bazel_runner/edc9951cbd41acd2e30f113cd8beddfe/external/com_github_p4lang_p4runtime/temp11858348925964151804/d966be4591ecc0fba3a001872854fcac0a64052c.zip to /home/runner/.cache/bazel/_bazel_runner/edc9951cbd41acd2e30f113cd8beddfe/external/com_github_p4lang_p4runtime/temp11858348925964151804: Zip entries cannot refer to files outside of their directory: d966be4591ecc0fba3a001872854fcac0a64052c.zip has a symlink LICENSE pointing to ../LICENSE
ERROR: /home/runner/work/pins-infra/pins-infra/WORKSPACE.bazel:21:[16](https://github.com/pins/pins-infra/actions/runs/10066426682/job/27827784607#step:8:17): fetching http_archive rule //external:com_github_p4lang_p4runtime: Traceback (most recent call last):
	File "/home/runner/.cache/bazel/_bazel_runner/edc9951cbd41acd2e30f113cd8beddfe/external/bazel_tools/tools/build_defs/repo/http.bzl", line 132, column 45, in _http_archive_impl
		download_info = ctx.download_and_extract(
Error in download_and_extract: java.io.IOException: Error extracting /home/runner/.cache/bazel/_bazel_runner/edc9951cbd41acd2e30f113cd8beddfe/external/com_github_p4lang_p4runtime/temp1[18](https://github.com/pins/pins-infra/actions/runs/10066426682/job/27827784607#step:8:19)58348925964151804/d966be4591ecc0fba3a001872854fcac0a64052c.zip to /home/runner/.cache/bazel/_bazel_runner/edc9951cbd41acd2e30f113cd8beddfe/external/com_github_p4lang_p4runtime/temp11858348925964151804: Zip entries cannot refer to files outside of their directory: d966be4591ecc0fba3a001872854fcac0a64052c.zip has a symlink LICENSE pointing to ../LICENSE
ERROR: Error computing the main repository mapping: no such package '@com_github_p4lang_p4runtime//': java.io.IOException: Error extracting /home/runner/.cache/bazel/_bazel_runner/edc9951cbd41acd2e30f113cd8beddfe/external/com_github_p4lang_p4runtime/temp11858348925964151804/d966be4591ecc0fba3a001872854fcac0a64052c.zip to /home/runner/.cache/bazel/_bazel_runner/edc9951cbd41acd2e30f113cd8beddfe/external/com_github_p4lang_p4runtime/temp11858348925964151804: Zip entries cannot refer to files outside of their directory: d966be4591ecc0fba3a001872854fcac0a64052c.zip has a symlink LICENSE pointing to ../LICENSE

@jonathan-dilorenzo
Remove license symlink since it's causing build issues for some githu…
ccaba2c 
…b build tools pulling in the new dependency.
chrispsommers
chrispsommers approved these changes Jul 23, 2024
View reviewed changes
Copy link
Collaborator

@chrispsommers chrispsommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, seems innocuous and expedient.Thanks.

jafingerhut
jafingerhut approved these changes Jul 24, 2024
View reviewed changes
Copy link
Contributor

@jafingerhut jafingerhut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jafingerhut jafingerhut merged commit 6e8c018 into main Jul 24, 2024
5 checks passed
@jafingerhut jafingerhut deleted the update_license branch July 24, 2024 04:04
@jonathan-dilorenzo
Copy link
Contributor Author

Thanks guys!

chrispsommers added a commit that referenced this pull request Aug 6, 2024
@chrispsommers @duskmoon314 @jonathan-dilorenzo
Sync version-1.4.0-rc to main (#489)
eb57617 
* Clarify wildcard read of counter and meter (#481)

Add 'Otherwise' to clarify how `id` and `index` are used in wildcard
read of counter and meter.

Close #478

* Remove license symlink since it's causing build issues for some github build tools pulling in the new dependency. (#488)

---------

Co-authored-by: Campbell He <[email protected]>
Co-authored-by: Jonathan DiLorenzo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrispsommers chrispsommers chrispsommers approved these changes

@jafingerhut jafingerhut jafingerhut approved these changes

@smolkaj smolkaj Awaiting requested review from smolkaj

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jonathan-dilorenzo @jafingerhut @chrispsommers