Fix likely-invalid potential shift of int by >32 bits

Signed-off-by: Mouse <[email protected]>
p4lang · Dec 12, 2024 · fc3cdd1 · fc3cdd1
1 parent 9f67eb5
commit fc3cdd1
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/backends/ebpf/codeGen.cpp b/backends/ebpf/codeGen.cpp
@@ -61,12 +61,13 @@ bool CodeGenInspector::preorder(const IR::Declaration_Variable *decl) {
     return false;
 }
 
+// We count on the optimizer to get rid of 64-bit arithmetic when it's unnecessary
 static cstring getMask(P4::TypeMap *typeMap, const IR::Node *node) {
     auto type = typeMap->getType(node, true);
     cstring mask = cstring::empty;
     if (auto tb = type->to<IR::Type_Bits>()) {
         if (tb->size != 8 && tb->size != 16 && tb->size != 32 && tb->size != 64)
-            mask = " & ((1 << " + Util::toString(tb->size) + ") - 1)";
+            mask = " & ((1ULL << " + Util::toString(tb->size) + ") - 1)";
     }
     return mask;
 }