fix(react): correctly apply overrides targeting single or multiple fi…

…eld keys
p3ol · Nov 18, 2024 · 46d8fef · 46d8fef
1 parent 4685ef6
commit 46d8fef
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 11 deletions.
diff --git a/packages/react/lib/Editable/Tab.tsx b/packages/react/lib/Editable/Tab.tsx
@@ -21,7 +21,6 @@ import type { EditableRef } from './index';
 import { useBuilder } from '../hooks';
 import Setting from './Setting';
 import SettingsGroup from './SettingsGroup';
-import { areArraysEqual } from '../utils';
 
 export interface TabProps extends ComponentPropsWithoutRef<'div'> {
   tab: ComponentSettingsTabObject | ComponentSettingsFieldObject;
@@ -85,10 +84,8 @@ const Tab = ({
           !component.settings?.fields?.find(s =>
             s.type !== 'tab' &&
             ((s as ComponentSettingsFieldObject).key === f.key ||
-            areArraysEqual(
-              (s as ComponentSettingsFieldObject).key as string[],
-              f.key as string[]
-            ))
+            [].concat((s as ComponentSettingsFieldObject).key)
+              .some(k => [].concat(f.key).includes(k)))
           )
         ) || [])
         .filter((field: ComponentSettingsFieldObject) =>

diff --git a/packages/react/lib/utils.ts b/packages/react/lib/utils.ts
@@ -31,9 +31,3 @@ export const sanitizeHTML = (content: string, opts?: {
     return '';
   }
 };
-
-export const areArraysEqual = (a: any[], b: any[]) =>
-  Array.isArray(a) &&
-  Array.isArray(b) &&
-  a.length === b.length &&
-  a.every((v, i) => v === b[i]);