Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency from secp256k1.swift to secp256k1.c has been changed. #73

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

TheHmmka
Copy link

Dependency from secp256k1.swift to secp256k1.c has been changed to fix compatibility with web3swift pod.

@codecov-commenter
Copy link

Codecov Report

Merging #73 (b03887f) into main (39917fd) will decrease coverage by 6.23%.
The diff coverage is 32.19%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main      #73      +/-   ##
==========================================
- Coverage   59.58%   53.35%   -6.23%     
==========================================
  Files         125      142      +17     
  Lines        9534    10825    +1291     
==========================================
+ Hits         5681     5776      +95     
- Misses       3853     5049    +1196     
Flag Coverage Δ
unittests 53.35% <32.19%> (-6.23%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...BlockchainClient/BlockchainClient+Extensions.swift 0.00% <0.00%> (ø)
...olanaSwift/BlockchainClient/BlockchainClient.swift 87.41% <ø> (ø)
.../BlockchainClient/Helpers/Borsh/BinaryReader.swift 22.22% <0.00%> (-70.09%) ⬇️
...lockchainClient/Helpers/Borsh/BorshSerialize.swift 0.00% <0.00%> (ø)
...wift/BlockchainClient/SolanaBlockchainClient.swift 10.52% <ø> (ø)
...olanaSwift/Extensions/AccountMeta+Extensions.swift 100.00% <ø> (ø)
...rces/SolanaSwift/Extensions/Error+Extensions.swift 0.00% <0.00%> (ø)
...urces/SolanaSwift/Models/AccountInstructions.swift 0.00% <ø> (ø)
...SolanaSwift/Models/BufferLayout/BufferLayout.swift 100.00% <ø> (ø)
...rces/SolanaSwift/Models/ConfirmedTransaction.swift 57.14% <ø> (ø)
... and 40 more

... and 7 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ngn999
Copy link

ngn999 commented Aug 5, 2024

What about SPM?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants