ETH-946 - save send fee payer #2194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fixed fee payer token auto selection - clarified some points
eduardmaximovich
had a problem deploying
to
manual
GitHub Actions
Error
Code coverage report
|
Comment on lines
+198
to
+204
| feePayerTokenCanCoverExpenses -> { | ||
| if (feePayerToken.isSOL) { | ||
| SwitchToSol | ||
| } else { | ||
| SwitchToSpl(feePayerToken) | ||
| } | ||
| } |
There was a problem hiding this comment.
I don't want to add a new useless state like NoSwitch, but it can be a better choise..
…ture/ETH-946-send-save-fee-payer
eduardmaximovich
had a problem deploying
to
manual
GitHub Actions
Error
gslevinkov
reviewed
Feb 13, 2024
| feesInSourceToken: FeeAmount, | ||
| expectedFee: FeeAmount | ||
| ) : this( | ||
| transactionFeeInSol = feesInSol.transactionFee, |
There was a problem hiding this comment.
god damn that's a lot of fees
There was a problem hiding this comment.
yes, adding them fixes this code https://github.com/p2p-org/key-app-android/pull/2194/files#diff-d782fed09c04c9160bdc93c75c19e0f8a4b12ee5934aa7e4daf3a97c933838c4R169
gslevinkov
reviewed
Feb 13, 2024
| } else { | ||
| feeRelayerFee.accountCreationFeeInFeePayerToken | ||
| } | ||
| return amount.fromLamports(feePayerToken.decimals).scaleLong() |
There was a problem hiding this comment.
scaleLong already inside fromLamports
gslevinkov
reviewed
Feb 13, 2024
| } | ||
|
|
||
| return amount.fromLamports(feePayerToken.decimals) | ||
| .scaleLong() |
gslevinkov
reviewed
Feb 13, 2024
| const val KEY_TOKEN_MINT = "TOKEN_MINT" | ||
| } | ||
|
|
||
| override fun restoreFeePayerToken(): Base58String? { |
There was a problem hiding this comment.
restore is more like domain layer method
storage only set/save get/require
There was a problem hiding this comment.
yep, refactored this point a bit
gslevinkov
reviewed
Feb 13, 2024
| val initialToken = if (selectedToken != null) selectedToken!! else userNonZeroTokens.first() | ||
| token = initialToken | ||
|
|
||
| // paths where this fee payer token is settling down: |
gslevinkov
approved these changes
Feb 13, 2024
…ture/ETH-946-send-save-fee-payer
…ken, fixed "fromLamports"
eduardmaximovich
had a problem deploying
to
manual
GitHub Actions
Error
eduardmaximovich
had a problem deploying
to
manual
GitHub Actions
Error
…ture/ETH-946-send-save-fee-payer
eduardmaximovich
had a problem deploying
to
manual
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Ticket
https://linear.app/etherean/issue/ETH-946/[android]-[keyapp]-zapominat-vybrannyj-token-kompensacii-dlya-send
Description of Work