ETH-951 - display full amount in send button #2193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eduardmaximovich
had a problem deploying
to
manual
GitHub Actions
Error
Code coverage report
|
gslevinkov
reviewed
Feb 13, 2024
| maxAccountCreationCountAllowed = 0, | ||
| maxAccountCreationAmountAllowed = BigInteger.ZERO | ||
| ), | ||
| processedFee = org.p2p.wallet.feerelayer.model.ProcessedFee( |
gslevinkov
reviewed
Feb 13, 2024
| @@ -35,6 +37,33 @@ class SendFeeTotal constructor( | |||
| val interestBearingPercent: BigDecimal? = null | |||
| ) : Parcelable { | |||
|
|
|||
| companion object { | |||
| fun createEmpty(): SendFeeTotal = SendFeeTotal( | |||
There was a problem hiding this comment.
No reason to do this; this code is unused in fact, and allocating static storage for it is pointless
gslevinkov
approved these changes
Feb 13, 2024
eduardmaximovich
had a problem deploying
to
manual
GitHub Actions
Error
…ture/ETH-951-display-full-sending-amount-in-button
eduardmaximovich
had a problem deploying
to
manual
GitHub Actions
Failure
eduardmaximovich
deleted the
feature/ETH-951-display-full-sending-amount-in-button
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Ticket
https://p2pvalidator.atlassian.net/browse/
Description of Work
[ what work was done in this ticket ]
Screenshots (Optional)