Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PWN-878 - migrate to SolScan #2180

Merged
merged 2 commits into from
Feb 6, 2024
Merged

PWN-878 - migrate to SolScan #2180

merged 2 commits into from
Feb 6, 2024

Conversation

gslevinkov
Copy link
Contributor

Jira Ticket

https://p2pvalidator.atlassian.net/browse/

Description of Work

[ what work was done in this ticket ]

Screenshots (Optional)

Screenshot #1 Screenshot #2 Screenshot #3
[Paste Pic 1] [Paste Pic 2] [Paste Pic 3]

Copy link

github-actions bot commented Feb 6, 2024

Code coverage report

Total Project Coverage 4.82% 💩

@@ -43,7 +43,7 @@
<string name="transaction_details_pending_transfer_description">The transaction will be completed in a few seconds</string>

<string name="transaction_details_share">Share</string>
<string name="transaction_details_explorer">Explorer</string>
<string name="transaction_details_explorer">SolScan</string>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for referral reward transaction details, I used SOLScan naming (history_strings.xml transaction_details_referral_button_second) because it's been added to figma

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@gslevinkov gslevinkov merged commit aac11f0 into develop Feb 6, 2024
3 of 4 checks passed
@gslevinkov gslevinkov deleted the feature/PWN-878-solscan branch February 6, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants