PWN-877 - add PNL feature toggle #2178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code coverage report
|
| @@ -87,7 +87,7 @@ class MyCryptoPresenter( | |||
| // pnl must restart it's 5 minutes timer after force refresh | |||
| // and we should restart it only if it was initially started | |||
| // other cases might indicate that we didn't start observer due to empty state | |||
| if (pnlInteractor.isStarted()) { | |||
| if (!pnlInteractor.canBeStarted()) { | |||
There was a problem hiding this comment.
it looks there are logical mistake: if it can't be started - restart
I suppose you wanted to check whether it can be started at all, considering feature toggle condition, in this case you need to add one more if:
if(pnlIntereactor.canBeStarted() && pnlInteractor.isStarted()) {
pnlInteractor.restartAndRefresh()
}
checking for "isStarted" is necessary here, because we should restart only if it was initially started after the first tokens load (see handleTokenState is UserTokensState.Loaded block)
eduardmaximovich
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Ticket
https://p2pvalidator.atlassian.net/browse/
Description of Work
[ what work was done in this ticket ]
Screenshots (Optional)