PWN-8973 - striga. signup otp timer #1890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gslevinkov
approved these changes
Jun 28, 2023
app/src/main/java/org/p2p/wallet/smsinput/striga/StrigaSmsInputInteractor.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/p2p/wallet/smsinput/striga/StrigaSmsInputPresenter.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/p2p/wallet/striga/di/StrigaSignupModule.kt
Outdated
Show resolved
Hide resolved
…ture/PWN-8973-striga-signup-otp-timer
ghost
approved these changes
Jun 28, 2023
…ture/PWN-8973-striga-signup-otp-timer
- also update user status after user creation using resulting model - fixed typo
…ture/PWN-8973-striga-signup-otp-timer
| ) { | ||
| val timer: Flow<Int> get() = smsInputTimer.smsInputTimerFlow | ||
| val isTimerNotActive: Boolean get() = !smsInputTimer.isTimerActive |
There was a problem hiding this comment.
it is used only in negative checking, so I decided to inverse the value
eduardmaximovich
had a problem deploying
to
manual
GitHub Actions
Failure
gslevinkov
approved these changes
Jun 29, 2023
app/src/main/java/org/p2p/wallet/smsinput/striga/StrigaSmsInputInteractor.kt
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Ticket
https://p2pvalidator.atlassian.net/browse/PWN-8973
Description of Work