-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PWN-8904 - Striga API. get_estimated_fees #1884
Merged
eduardmaximovich
merged 6 commits into
feature/PWN-8895-striga-payment-api
from
feature/PWN-8904-striga-api-fees
Jun 28, 2023
Merged
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
faceffa
PWN-8904 - Striga API. get_estimated_fees
gslevinkov 20e2fd6
PWN-8904 - comment fixes
gslevinkov 5200b00
PWN-8904 - change base url
gslevinkov d58bf06
Merge branch 'feature/PWN-8895-striga-payment-api' of github_p2p:p2p-…
eduardmaximovich 3f3008d
PWN-8904 - add StrigaUserWalletsMapper to koin
eduardmaximovich a5af9d4
PWN-8904 - add ending slashes to new striga urls
eduardmaximovich File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
18 changes: 18 additions & 0 deletions
18
...c/main/java/org/p2p/wallet/striga/wallet/api/request/StrigaOnchainWithdrawalFeeRequest.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
package org.p2p.wallet.striga.wallet.api.request | ||
|
||
import com.google.gson.annotations.SerializedName | ||
|
||
/** | ||
* @param amountInUnits The amount denominated in the smallest divisible unit of the sending currency. | ||
* For example: cents or satoshis | ||
*/ | ||
class StrigaOnchainWithdrawalFeeRequest( | ||
@SerializedName("userId") | ||
val userId: String, | ||
@SerializedName("sourceAccountId") | ||
val sourceAccountId: String, | ||
@SerializedName("whitelistedAddressId") | ||
val whitelistedAddressId: String, | ||
@SerializedName("amount") | ||
val amountInUnits: String, | ||
) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20 changes: 20 additions & 0 deletions
20
...main/java/org/p2p/wallet/striga/wallet/api/response/StrigaOnchainWithdrawalFeeResponse.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
package org.p2p.wallet.striga.wallet.api.response | ||
|
||
import com.google.gson.annotations.SerializedName | ||
|
||
data class StrigaOnchainWithdrawalFeeResponse( | ||
@SerializedName("totalFee") | ||
val totalFee: String, | ||
@SerializedName("networkFee") | ||
val networkFee: String, | ||
@SerializedName("ourFee") | ||
val ourFee: String, | ||
@SerializedName("theirFee") | ||
val theirFee: String, | ||
@SerializedName("feeCurrency") | ||
val feeCurrency: String, | ||
@SerializedName("gasLimit") | ||
val gasLimit: String, | ||
@SerializedName("gasPrice") | ||
val gasPrice: String | ||
) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is reused across two api requests