PWN-8904 - Striga API. get_user_wallets #1883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1sakov
approved these changes
Jun 27, 2023
| @@ -105,4 +111,27 @@ class StrigaWalletRemoteRepository( | |||
| ) | |||
| } | |||
| } | |||
|
|
|||
| override suspend fun getUserWallet(): StrigaDataLayerResult<StrigaUserWallet?> { | |||
There was a problem hiding this comment.
let's have this function return a non-null type and throw an exception if it can't find any wallets, that would be a pretty weird case, I reckon
eduardmaximovich
approved these changes
Jun 27, 2023
gslevinkov
merged commit 44a66ec
into
feature/PWN-8895-striga-payment-api
2 of 3 checks passed
eduardmaximovich
added a commit
that referenced
this pull request
Jun 28, 2023
* PWN-8895, PWN-8776 - striga. payment api * PWN-8895, PWN-8776 - removed class doc * PWN-8895, PWN-8776 - comment fix * PWN-8904 - Striga API. get_user_wallets (#1883) * PWN-8895 - namings and improvements * PWN-8895 - merge * PWN-8895 - amount -> amountInUnits * PWN-8904 - Striga API. get_estimated_fees (#1884) * PWN-8904 - Striga API. get_estimated_fees * PWN-8904 - comment fixes * PWN-8904 - change base url * PWN-8904 - add StrigaUserWalletsMapper to koin * PWN-8904 - add ending slashes to new striga urls --------- Co-authored-by: Eduard Maximovich <[email protected]> --------- Co-authored-by: Gleb Levinkov (p2p) <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Ticket
https://p2pvalidator.atlassian.net/browse/PWN-8904