PWN-9042, PWN-9043, PWN-9057, PWN-9050, PWN-9046 - device share fixes #1875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
June 26, 2023 13:05
ghost
requested review from
1sakov,
Davran331122,
gslevinkov and
eduardmaximovich
as code owners
ghost
self-assigned this
|
thanks for naming all tickets in the PR' title! |
gslevinkov
approved these changes
Jun 26, 2023
app/src/main/java/org/p2p/wallet/auth/repository/RestoreFlowDataLocalRepository.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/p2p/wallet/smsinput/updatedevice/UpdateDeviceSmsInputFragment.kt
Outdated
Show resolved
Hide resolved
Code coverage report
|
1sakov
approved these changes
Jun 26, 2023
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Ticket
https://p2pvalidator.atlassian.net/browse/PWN-9042
https://p2pvalidator.atlassian.net/browse/PWN-9043
https://p2pvalidator.atlassian.net/browse/PWN-9057
https://p2pvalidator.atlassian.net/browse/PWN-9050
https://p2pvalidator.atlassian.net/browse/PWN-9046
Description of Work
PWN-9042 - set torusKeyTimestamp to 0 if torus key is null (on error cases)
PWN-9043 - text for incorrect account updated
PWN-9057 - errors handling fixed
PWN-9050 - backStack return fix
PWN-9046 - fix intercom on restore flow