Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PWN-8982 - Striga. TopUp loading fixes + develop fix #1854

Merged
merged 6 commits into from
Jun 20, 2023
Merged

PWN-8982 - Striga. TopUp loading fixes + develop fix #1854

merged 6 commits into from
Jun 20, 2023

Conversation

gslevinkov
Copy link
Contributor

@gslevinkov gslevinkov self-assigned this Jun 20, 2023
@gslevinkov gslevinkov requested a review from a user June 20, 2023 10:24
@gslevinkov gslevinkov changed the base branch from develop to feature/NO-TICKET-add-metadata-logger June 20, 2023 10:25
@github-actions
Copy link

github-actions bot commented Jun 20, 2023 •
edited
Loading

Code coverage report

File Coverage [20.63%]
app/src/main/java/org/p2p/wallet/auth/gateway/parser/CountryCodeXmlParser.kt 78.18%
app/src/main/java/org/p2p/wallet/auth/gateway/repository/mapper/BorshSerializable.kt 0.00%
app/src/main/java/org/p2p/wallet/auth/gateway/repository/mapper/GatewayServiceCreateWalletMapper.kt 0.00%
app/src/main/java/org/p2p/wallet/auth/gateway/repository/mapper/GatewayServiceUpdateMetadataMapper.kt 0.00%
app/src/main/java/org/p2p/wallet/auth/interactor/MetadataChangesLogger.kt 0.00%
app/src/main/java/org/p2p/wallet/auth/interactor/MetadataInteractor.kt 0.00%
app/src/main/java/org/p2p/wallet/auth/model/MetadataLoadStatus.kt 0.00%
app/src/main/java/org/p2p/wallet/auth/model/PhoneNumberWithCode.kt 37.50%
app/src/main/java/org/p2p/wallet/auth/web3authsdk/Web3AuthDurationTracker.kt 0.00%
app/src/main/java/org/p2p/wallet/sell/interactor/SellInteractor.kt 0.00%
app/src/main/java/org/p2p/wallet/smsinput/striga/StrigaSmsInputInteractor.kt 0.00%
app/src/main/java/org/p2p/wallet/smsinput/striga/StrigaSmsInputPresenter.kt 0.00%
app/src/main/java/org/p2p/wallet/striga/signup/interactor/StrigaSignupInteractor.kt 85.15%
app/src/main/java/org/p2p/wallet/striga/ui/TopUpWalletPresenter.kt 0.00%
app/src/main/java/org/p2p/wallet/striga/user/StrigaStorage.kt 0.00%
app/src/main/java/org/p2p/wallet/striga/user/interactor/StrigaUserInteractor.kt 0.00%
app/src/main/java/org/p2p/wallet/striga/user/model/StrigaUserDetails.kt 0.00%
app/src/main/java/org/p2p/wallet/striga/user/repository/StrigaUserRemoteRepository.kt 22.64%
app/src/main/java/org/p2p/wallet/striga/user/repository/StrigaUserRepositoryMapper.kt 51.14%
app/src/main/java/org/p2p/wallet/striga/user/repository/StrigaUserStatusDestinationMapper.kt 0.00%
app/src/main/java/org/p2p/wallet/striga/user/repository/StrigaUserStatusRepository.kt 0.00%
Total Project Coverage 7.03%

eduardmaximovich
eduardmaximovich reviewed Jun 20, 2023
View reviewed changes
app/src/main/java/org/p2p/wallet/striga/ui/TopUpWalletPresenter.kt Outdated
}
}

private suspend fun checkNeededStrigaDataLoaded() {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
private suspend fun checkNeededStrigaDataLoaded() {
private suspend fun ensureNeededStrigaDataLoaded() {

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a fire!!

@gslevinkov gslevinkov force-pushed the feature/PWN-8982-striga-metadata-fix branch from d1d1a0c to 555fa3b Compare June 20, 2023 11:25
@gslevinkov
Merge branch 'feature/NO-TICKET-add-metadata-logger' into feature/PWN…
61dd546 
…-8982-striga-metadata-fix

# Conflicts:
#	app/src/main/java/org/p2p/wallet/debug/pushservice/DebugWeb3Fragment.kt
Base automatically changed from feature/NO-TICKET-add-metadata-logger to develop June 20, 2023 11:48
@gslevinkov gslevinkov merged commit 00153b8 into develop Jun 20, 2023
2 of 3 checks passed
@gslevinkov gslevinkov deleted the feature/PWN-8982-striga-metadata-fix branch June 20, 2023 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eduardmaximovich eduardmaximovich eduardmaximovich left review comments

@Davran331122 Davran331122 Davran331122 approved these changes

@1sakov 1sakov 1sakov approved these changes

Assignees

@gslevinkov gslevinkov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gslevinkov @1sakov @Davran331122 @eduardmaximovich