NO-TICKET - Add metadata change logs #1852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gslevinkov
commented
Jun 20, 2023
| PhoneNumberUtil.PhoneNumberFormat.INTERNATIONAL | ||
| ) | ||
| internationalFormat.replace("+$phoneCode", emptyString()) | ||
| if (exampleNumber != null) { |
There was a problem hiding this comment.
to remove unwanted trash logs when exampleNumber is null
gslevinkov
commented
Jun 20, 2023
| @@ -132,6 +132,7 @@ class GatewayServiceCreateWalletMapper( | |||
| phoneNumberTimestampSec = epochUnixTimeSeconds, | |||
| socialShareOwnerEmail = socialShareOwnerId, | |||
| emailTimestampSec = epochUnixTimeSeconds, | |||
| authProviderTimestampSec = epochUnixTimeSeconds | |||
There was a problem hiding this comment.
we forgot to add this here
gslevinkov
commented
Jun 20, 2023
| ?: if (web3AuthData != null) "Not loaded" else "None" | ||
|
|
||
| textViewWeb3Value.text = web3DataJson | ||
| textViewMetadataValue.text = metadataJson | ||
|
|
||
| buttonMetadataLogs.setOnClickListener { |
There was a problem hiding this comment.
share logs in debug panel
gslevinkov
commented
Jun 20, 2023
| @@ -92,6 +93,15 @@ object NetworkModule : InjectionModule { | |||
| interceptor = RpcInterceptor(get(), get()) | |||
| ) | |||
| } | |||
| single<RpcApi> { | |||
There was a problem hiding this comment.
moved RpcApi to our module because there was not enough logging for update_metadata requests
1sakov
reviewed
Jun 20, 2023
| .orEmpty() | ||
| if (cipheredMetadata.isNotBlank()) { | ||
| // get json like GatewayOnboardingMetadataCiphered | ||
| val metadataAsJson = kotlin.runCatching { |
There was a problem hiding this comment.
if you move runCatching to the next line, it would be much easier to read
1sakov
reviewed
Jun 20, 2023
| single<RpcApi> { | ||
| getRetrofit( | ||
| // no need for baseUrl here, we pass URL inside RpcApi | ||
| baseUrl = "http://localhost/", |
There was a problem hiding this comment.
I think that needs to be refactored.
Move URL passing here.
@davran1001 fyi
eduardmaximovich
approved these changes
Jun 20, 2023
Davran331122
approved these changes
Jun 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Work
metadatafield onget_metadataandupdate_metadatarequests