PWN-8614 - Add new amplitude events, and modify current #1850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Davran331122
requested review from
gslevinkov and
eduardmaximovich
as code owners
gslevinkov
suggested changes
Jun 19, 2023
app/src/main/java/org/p2p/wallet/history/analytics/HistoryAnalytics.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/p2p/wallet/home/analytics/HomeAnalytics.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/p2p/wallet/home/analytics/HomeAnalytics.kt
Outdated
Show resolved
Hide resolved
| @@ -424,6 +432,20 @@ class HomePresenter( | |||
| } | |||
| } | |||
|
|
|||
| override fun onSellClicked() { | |||
| sellAnalytics.logSellSubmitClicked() | |||
There was a problem hiding this comment.
you can inject analytics inside Fragment to remove jumping from presenter to view just for this
There was a problem hiding this comment.
I think it's more clear, yeah for now it's dump, but maybe we will need to add some logic in future xD
it can not be avoided ))
| } | ||
|
|
||
| override fun onOpenTwitterClicked() { | ||
| analytics.logSettingItemClicked(SETTING_ITEM_TWITTER) |
There was a problem hiding this comment.
same
inject analytics inside fragment
makes Contract cleaner
app/src/main/java/org/p2p/wallet/settings/ui/settings/SettingsPresenterAnalytics.kt
Show resolved
Hide resolved
1sakov
approved these changes
Jun 20, 2023
gslevinkov
approved these changes
Jun 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Ticket
https://p2pvalidator.atlassian.net/browse/PWN-8614