PWN-8969 - renamed function

p2p-org · Jun 23, 2023 · 6e4f2d5 · 6e4f2d5
1 parent 1cda84c
commit 6e4f2d5
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 11 deletions.
diff --git a/app/src/main/java/org/p2p/wallet/smsinput/striga/StrigaSmsInputInteractor.kt b/app/src/main/java/org/p2p/wallet/smsinput/striga/StrigaSmsInputInteractor.kt
@@ -99,14 +99,14 @@ class StrigaSmsInputInteractor(
     }
 
     private fun isExceededVerificationAttempts(): Boolean {
-        return !DateTimeUtils.checkTimerIsOver(
+        return !DateTimeUtils.isTimestampExpired(
             strigaStorage.smsExceededVerificationAttemptsMillis,
             EXCEEDED_VERIFICATION_ATTEMPTS_TIMEOUT_MILLIS
         )
     }
 
     private fun isExceededResendAttempts(): Boolean {
-        return !DateTimeUtils.checkTimerIsOver(
+        return !DateTimeUtils.isTimestampExpired(
             strigaStorage.smsExceededResendAttemptsMillis,
             EXCEEDED_RESEND_ATTEMPTS_TIMEOUT_MILLIS
         )

diff --git a/app/src/main/java/org/p2p/wallet/utils/DateTimeUtils.kt b/app/src/main/java/org/p2p/wallet/utils/DateTimeUtils.kt
@@ -156,7 +156,7 @@ object DateTimeUtils {
         return String.format(Locale.US, "%02d:%02d", m, s)
     }
 
-    fun checkTimerIsOver(timeMs: Long, expireDurationMs: Long): Boolean {
+    fun isTimestampExpired(timeMs: Long, expireDurationMs: Long): Boolean {
         return timeMs == 0L || System.currentTimeMillis() - timeMs >= expireDurationMs
     }
 

diff --git a/app/src/test/java/org/p2p/wallet/utils/DateTimeUtilsTest.kt b/app/src/test/java/org/p2p/wallet/utils/DateTimeUtilsTest.kt
@@ -9,32 +9,32 @@ import kotlin.time.Duration.Companion.seconds
 class DateTimeUtilsTest {
 
     @Test
-    fun `GIVEN initial timer with 10 seconds expiration WHEN checkTimerIsOver THEN check time is not over`() {
+    fun `GIVEN initial timer with 10 seconds expiration WHEN isTimestampExpired THEN check time is not over`() {
         val savedTime = System.currentTimeMillis()
         val expiration = 10.seconds.inWholeMilliseconds
 
         assertFalse(
-            DateTimeUtils.checkTimerIsOver(savedTime, expiration)
+            DateTimeUtils.isTimestampExpired(savedTime, expiration)
         )
     }
 
     @Test
-    fun `GIVEN almost expired timer with 10 seconds expiration WHEN checkTimerIsOver THEN check time is not over`() {
+    fun `GIVEN almost expired timer with 10 seconds expiration WHEN isTimestampExpired THEN check time is not over`() {
         val expiration = 10.seconds.inWholeMilliseconds
         val savedTime = System.currentTimeMillis() - 9.5.seconds.inWholeMilliseconds
 
         assertFalse(
-            DateTimeUtils.checkTimerIsOver(savedTime, expiration)
+            DateTimeUtils.isTimestampExpired(savedTime, expiration)
         )
     }
 
     @Test
-    fun `GIVEN expired timer with 10 seconds expiration WHEN checkTimerIsOver THEN check time is over`() {
+    fun `GIVEN expired timer with 10 seconds expiration WHEN isTimestampExpired THEN check time is over`() {
         val expiration = 10.seconds.inWholeMilliseconds
         val savedTime = System.currentTimeMillis() - expiration
 
         assertTrue(
-            DateTimeUtils.checkTimerIsOver(savedTime, expiration)
+            DateTimeUtils.isTimestampExpired(savedTime, expiration)
         )
     }
 
@@ -44,7 +44,7 @@ class DateTimeUtilsTest {
         val savedTime = System.currentTimeMillis() - 1.days.inWholeMilliseconds
 
         assertTrue(
-            DateTimeUtils.checkTimerIsOver(savedTime, expiration)
+            DateTimeUtils.isTimestampExpired(savedTime, expiration)
         )
     }
 
@@ -54,7 +54,7 @@ class DateTimeUtilsTest {
         val savedTime = 0L
 
         assertTrue(
-            DateTimeUtils.checkTimerIsOver(savedTime, expiration)
+            DateTimeUtils.isTimestampExpired(savedTime, expiration)
         )
     }
 }