feat: cosmos-exporter chart #1
Conversation
COSMOS-2655
felichita
force-pushed
the
felichita/cosmos-exporter
branch
from
d7b9885 to
6078890
Compare
| labels: | ||
| {{- include "cosmos-exporter.labels" $ | nindent 4 }} | ||
| k8s-app: {{ $.Values.appName }} | ||
| spec: |
There was a problem hiding this comment.
If we are open sourcing this its probably worth adding resources and affinity / nodeSelector anyway.
| {{- toYaml . | nindent 12 }} | ||
| {{- end }} | ||
| imagePullSecrets: | ||
| {{- toYaml $.Values.imagePullSecrets | nindent 8 }} |
There was a problem hiding this comment.
would be nice to make the imagePullSecret creation optional and allow optionally providing an existing secret in case the secret is created by another process
| annotations: | ||
| "helm.sh/hook": pre-install,pre-upgrade | ||
| "helm.sh/hook-weight": "-10" | ||
| "helm.sh/hook-delete-policy": before-hook-creation |
There was a problem hiding this comment.
To widen CI/CD options, can you also add ArgoCD's PreSync hook? as helm hooks are not supported in ArgoCD and will be synced in default ordering
| annotations: | ||
| "helm.sh/hook": pre-install,pre-upgrade | ||
| "helm.sh/hook-weight": "-10" | ||
| "helm.sh/hook-delete-policy": before-hook-creation |
| registry: ghcr.io | ||
| username: cosmos | ||
| password: secret | ||
| email: [email protected] |
There was a problem hiding this comment.
if this will be open-sourced I guess we need to leave out our P2P information from default values
| - key: blch | ||
| operator: In | ||
| values: | ||
| - "true" |
There was a problem hiding this comment.
I wouldn't make the blch: true label default as well
| replicas: 1 | ||
|
|
||
| appImage: | ||
| repo: ghcr.io/p2p-org/rcosmos-exporter |
chliddle
force-pushed
the
main
branch
7 times, most recently
from
5087892 to
86509b5
Compare
COSMOS-2655