Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: golang printf lint error #4

Merged
merged 1 commit into from
Aug 21, 2024
Merged

fix: golang printf lint error #4

merged 1 commit into from
Aug 21, 2024

Conversation

minniux
Copy link

@minniux minniux commented Aug 21, 2024

This is a small change, mainly switching fmt.printf with fmt.print to fix the following:

While building a new docker image for Stride, the lint step is failing as printf is specified without formatting

P.S. In the GH actions output there are no enough details, but running the lint locally makes it clear:

docker/docker.go:74:15: printf: non-constant format string in call to fmt.Printf (govet)
			fmt.Printf(dockerLogLine.Stream)

@minniux minniux changed the title Fix golang printf lint error Fix: golang printf lint error Aug 21, 2024
@minniux minniux changed the title Fix: golang printf lint error fix: golang printf lint error Aug 21, 2024
@minniux minniux merged commit 3f58cc3 into main Aug 21, 2024
4 of 5 checks passed
@minniux minniux deleted the fixLintError branch August 21, 2024 10:20
felichita pushed a commit that referenced this pull request Aug 25, 2024
alexeyzhigaev pushed a commit that referenced this pull request Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants