Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restructure CTL1 input handling #129

Draft
wants to merge 45 commits into
base: L1PF_14_2_X
Choose a base branch
from
Draft

Restructure CTL1 input handling #129

wants to merge 45 commits into from

Conversation

cerminar
Copy link

@cerminar cerminar commented Nov 27, 2024 •
edited
Loading

PR description:

In preparation of the integration of the GCT emulated clusters, this PR rewrites the handling of the calorimeter inputs by the CTL1 emulator.
In particular:

  • drop the conversion of the input calorimeter objects to PFCluster moving all needed manipulations (calibs, ID models etc etc) to the emulator
  • setup to build "decoded" calorimeter objects starting from digitized words via unpackers
  • add the possibility to write PFCluster collections directly from the CTL1 emulator AFTER the decoding (this will be useful for training models using exactly the decoded information)
  • adds more realistic HGCal decoding (update to more recent interface document)
  • add emulation of multiclass ID within the HGCal decoding step.
  • PFCandidate ref to source needs to become polimorfic

More to come!
NOTE: I open this to ease the development....while the code compiles, it is not meant to be functional

PR validation:

None for now....:(

cerminar and others added 30 commits November 11, 2024 18:04
@cerminar
Initial prototype to integrate the new multiclass model
86346a0
@cerminar
skeleton for hgc multiclass id integration
43d2e3d
@cerminar
update multiclass BDT WP & reorganize conifer model diretory
ce46e0c
@cerminar
Clean up conifer directory
ded7b44
@cerminar
Read BDT path correctly
6eb55a7
@cerminar
fix PU rejection bug with multi classifier
cad5651
@cerminar
Bug fix for BDT score not being applied
72878fa
@cerminar
Simpler way to debug the cluster & it connection of BDT scores
8fb65ed
@cerminar
clean up code
57617d9
@cerminar
Update model with meanz offset & confier header fix & offline-softmax
0dbf52e
@cerminar
Switch to emulated crystal clusters and store digitized version in PF…
548c6f1 
…Clusters
@cerminar
Address empty hwQual in CrystalClusters
0fc656f
@cerminar
fix conversion to 64bits
0508634
@cerminar
Integrate hgcId & track truth matching on v9
b69309a
@cerminar
compatiable with track truth matching
3f32485
@cerminar
Skeleton of barrel TkEleComposite ID
da02f7b
@cerminar
Complete first working version
91e5cee
@cerminar
reduce verbosiry
0c3edf3
@cerminar
Address tight WP assignment
9165ad4
@cerminar
Fix pt frac
7897185
@cerminar
Fix track pt cut and elliptic matching for new EB model
632bdca
@cerminar
New model for the endcap
4366b05
@cerminar
Fix digi object for selected clusters
bcd7903
@cerminar
Fix nput features and precision for new TKEle EB model
7ff3f67
@cerminar
roll back to Peter's composite ID in HGCal
caa1c22
@cerminar
v9 + GCT + EBcomposite + EEmulticlass_tinymodel
c425b11
@cerminar
update HGC model to have pTbinned WP
c673f00
@cerminar
set photon WP to false and fix the quality for collection before sele…
7c19bba 
…ction
@cerminar
Fist step towards removing input conversion to PFCluster.
026e1d7 
- only working mechanics. HGCal content still empty
- PFCandidates now own a pointer to L1Candidates
- PFProdure can write out PFClusters with decoded information
- started moving functionality of PFCLuster converters in PF producer
@cerminar
Initial implementation of HGC cluster encoding/decoding
aa5a59d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@cerminar