-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve criteria performance #66
Conversation
I've added a github action with benchmarks for |
0c4a1ca
to
b0bd692
Compare
Benchmark Results
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
42c91a8
to
00ae4f0
Compare
@p-gw Thank you for the review. I've addressed your comments + tweaked the infomax and biquartimin. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, very nice PR!
Another pass on optimizing criterion performance:
Ones() * M
and similar constructs withsum(M, dims=...)
-- it should be fastertr(A' * B)
withdot(A, B)
where possible -- should be much faster∇Q
(if available) as a temporary matrix for intermediate operations to reduce memory footprint