New files (NavBar) #24
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinnhli
reviewed
May 24, 2018
index.html
Outdated
| <button id="genericButton" onclick="buttonCopy()">COPY</button> | ||
| <button id="genericButton" onclick="buttonCut()">CUT</button> | ||
| <button id="genericButton" onclick="buttonPaste()">PASTE</button> | ||
| <br> |
There was a problem hiding this comment.
You probably mean class="genericButton" and not id.
stylesheet.css
Outdated
| cursor: not-allowed; | ||
| } | ||
|
|
||
| #genericButton { |
There was a problem hiding this comment.
Change this to ".genericButton" to make it with with classes
|
Okay. I will make the changes and push the files.
…On Thu, May 24, 2018 at 16:40 Justin Li ***@***.***> wrote:
***@***.**** commented on this pull request.
A couple small changes, but otherwise looks good.
------------------------------
In index.html
<#24 (comment)>
:
> @@ -34,6 +34,15 @@
addBlocksHTML();
};
</script>
+ <button id="genericButton" onclick="buttonUndo()">UNDO</button>
+ <button id="genericButton" onclick="buttonRedo()">REDO</button>
+ <button id="genericButton" onclick="buttonDefaultZoom()">DEFAULT ZOOM</button>
+ <button id="genericButton" onclick="buttonZoomIn()">ZOOM IN</button>
+ <button id="genericButton" onclick="buttonZoomOut()">ZOOM OUT</button>
+ <button id="genericButton" onclick="buttonCopy()">COPY</button>
+ <button id="genericButton" onclick="buttonCut()">CUT</button>
+ <button id="genericButton" onclick="buttonPaste()">PASTE</button>
+ <br>
You probably mean class="genericButton" and not id.
------------------------------
In stylesheet.css
<#24 (comment)>
:
> @@ -63,5 +63,30 @@ body {
#parseButton:disabled {
background-color: grey;
color: white;
- cursor: default;
-}
+ cursor: not-allowed;
+}
+
+#genericButton {
Change this to ".genericButton" to make it with with classes
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#24 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AltOVdAP8uGRebdmyxQxjU7mKVA6-fDoks5t10TmgaJpZM4ULg4Z>
.
|
justinnhli
reviewed
May 25, 2018
| * @returns {undefined} | ||
| */ | ||
| function buttonPaste(){ | ||
| document.execCommand('Paste', data); |
There was a problem hiding this comment.
I am confused by this line - what's data?
| @@ -1,7 +1,7 @@ | |||
| /* global require, module, editor, editorState, blockDict, monaco */ | |||
|
|
|||
There was a problem hiding this comment.
You'll need to add your new functions into this list to fix the lint.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I followed your instructions in the e-mail.