Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for labels attribute #13

Merged
merged 14 commits into from
Feb 28, 2024
Merged

Add support for labels attribute #13

merged 14 commits into from
Feb 28, 2024

Conversation

benjaminleonard
Copy link
Contributor

This was mostly an experiment to try and understand how this codebase worked, if this is janky or an inconvenience feel free to ignore!

The generated SDK seems a little out of date because it added a bunch of things I didn't touch, I didn't include those in the commit.

One question I have, is that this API leaves fields like authors unprocessed as a single string, rather than an array of strings. Is there a reason not to do that here? It might open the door for some more robust filtering and linting in the future.

@benjaminleonard benjaminleonard changed the title Add support for labels attributes Add support for labels attribute Aug 25, 2023
@augustuswm
Copy link
Contributor

Authors are a string only because that is how they were previously stored. I agree it makes sense to instead parse them here and store them as a string array.

It is probably worth doing the same for labels so that we can have better queries for filtering on them.

@benjaminleonard
Copy link
Contributor Author

Reviving this – just merged main into it.

Is there an easy way to get rfd-api running without configuring all the oauth stuff?

@augustuswm
Copy link
Contributor

Not super easily at the moment. Or more accurately it is runable, but you would not be able to actively authenticate to it. Adding some kind of development authentication is something I need to work on.

@augustuswm
Copy link
Contributor

Most of the errors here look to be related to dependencies updates from progenitor. I just fixed these in a different project (that is using the new progenitor output config). Let me see if I can this repo switched over as well.

@augustuswm augustuswm merged commit 648c224 into main Feb 28, 2024
12 checks passed
@augustuswm augustuswm deleted the add-labels-attr branch February 28, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants