Split out pdfs

oxidecomputer · Dec 21, 2024 · 6b9b132 · 6b9b132
1 parent ef9f0ef
commit 6b9b132
Show file tree

Hide file tree

Showing 2 changed files with 37 additions and 7 deletions.
diff --git a/rfd-api/src/context.rs b/rfd-api/src/context.rs
@@ -17,8 +17,8 @@ use rfd_data::{
 use rfd_github::{GitHubError, GitHubNewRfdNumber, GitHubRfdRepo};
 use rfd_model::{
     schema_ext::{ContentFormat, Visibility},
-    storage::{JobStore, RfdFilter, RfdMetaStore, RfdStorage, RfdStore},
-    CommitSha, FileSha, Job, NewJob, Rfd, RfdId, RfdMeta, RfdRevision, RfdRevisionId,
+    storage::{JobStore, RfdFilter, RfdMetaStore, RfdPdfFilter, RfdPdfStore, RfdStorage, RfdStore},
+    CommitSha, FileSha, Job, NewJob, Rfd, RfdId, RfdMeta, RfdPdf, RfdRevision, RfdRevisionId,
 };
 use rsa::{
     pkcs1::{DecodeRsaPrivateKey, EncodeRsaPrivateKey},
@@ -491,6 +491,27 @@ impl RfdContext {
         self.view_rfd_revision(caller, rfd_number, None).await
     }
 
+    #[instrument(skip(self, caller))]
+    pub async fn view_rfd_pdfs(
+        &self,
+        caller: &Caller<RfdPermission>,
+        rfd_number: i32,
+        revision: Option<RfdRevisionIdentifier>,
+    ) -> ResourceResult<Vec<RfdPdf>, StoreError> {
+        let rfd = self.get_rfd_meta(caller, rfd_number, revision).await?;
+        let pdfs = RfdPdfStore::list(
+            &*self.storage,
+            vec![RfdPdfFilter::default()
+                .rfd(Some(vec![rfd.id]))
+                .rfd_revision(Some(vec![rfd.content.id]))],
+            &ListPagination::unlimited(),
+        )
+        .await
+        .to_resource_result()?;
+
+        Ok(pdfs)
+    }
+
     #[instrument(skip(self, caller, content))]
     pub async fn update_rfd_content(
         &self,

diff --git a/rfd-api/src/endpoints/rfd.rs b/rfd-api/src/endpoints/rfd.rs
@@ -13,7 +13,7 @@ use rfd_data::{
 };
 use rfd_model::{
     schema_ext::{ContentFormat, Visibility},
-    Rfd, RfdRevisionId,
+    Rfd, RfdPdf, RfdRevisionId,
 };
 use schemars::JsonSchema;
 use serde::{Deserialize, Serialize};
@@ -141,7 +141,7 @@ pub async fn view_rfd(
 pub async fn view_rfd_pdf(
     rqctx: RequestContext<RfdContext>,
     path: Path<RfdPathParams>,
-) -> Result<HttpResponseOk<RfdWithContent>, HttpError> {
+) -> Result<HttpResponseOk<Vec<RfdPdf>>, HttpError> {
     let ctx = rqctx.context();
     let caller = ctx.v_ctx().get_caller(&rqctx).await?;
     let path = path.into_inner();
@@ -225,7 +225,7 @@ pub async fn view_rfd_revision(
 pub async fn view_rfd_revision_pdf(
     rqctx: RequestContext<RfdContext>,
     path: Path<RfdRevisionPathParams>,
-) -> Result<HttpResponseOk<RfdWithContent>, HttpError> {
+) -> Result<HttpResponseOk<Vec<RfdPdf>>, HttpError> {
     let ctx = rqctx.context();
     let caller = ctx.v_ctx().get_caller(&rqctx).await?;
     let path = path.into_inner();
@@ -384,8 +384,17 @@ async fn view_rfd_pdf_op(
     caller: &Caller<RfdPermission>,
     number: String,
     revision: Option<RfdRevisionIdentifier>,
-) -> Result<HttpResponseOk<RfdWithContent>, HttpError> {
-    unimplemented!()
+) -> Result<HttpResponseOk<Vec<RfdPdf>>, HttpError> {
+    if let Ok(rfd_number) = number.parse::<i32>() {
+        Ok(HttpResponseOk(
+            ctx.view_rfd_pdfs(caller, rfd_number, revision).await?,
+        ))
+    } else {
+        Err(client_error(
+            ClientErrorStatusCode::BAD_REQUEST,
+            "Malformed RFD number",
+        ))
+    }
 }
 
 #[instrument(skip(ctx, caller), fields(caller = ?caller.id), err(Debug))]