Skip to content

[support bundle] Add health checks to support bundles #8102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 59 commits into
base: main
Choose a base branch
from

Conversation

smklein
Copy link
Collaborator

@smklein smklein commented May 6, 2025

Mostly fixes #8073

Does not completely cover the existing health check, but covers most of the cases

smklein added 30 commits April 11, 2025 10:33
@smklein smklein force-pushed the sb-health-check branch from 64bef6f to 70a9518 Compare May 6, 2025 17:55
@leftwo
Copy link
Contributor

leftwo commented May 7, 2025

Is there a way we could run these health checks outside of the support bundle gathering?
Or, does that require making a stand-alone version (which is fine, just want to know how).

Ideally we can transition the current bash health check script into using this, so we only have
(as much as is possible) a single place that gathers the data we want.

@papertigers
Copy link
Contributor

Is there a way we could run these health checks outside of the support bundle gathering? Or, does that require making a stand-alone version (which is fine, just want to know how).

Ideally we can transition the current bash health check script into using this, so we only have (as much as is possible) a single place that gathers the data we want.

That's why we ended up with the sled-diagnostics crate which would allow you to call whatever you would like outside of support bundle gathering. The crate could include a binary if that would be helpful that could expose common things such as the health check commands. How does the health check script make it onto a sled today?

Base automatically changed from omdb-sb-download-whole-thing to main May 7, 2025 23:30
@leftwo
Copy link
Contributor

leftwo commented May 7, 2025

Is there a way we could run these health checks outside of the support bundle gathering? Or, does that require making a stand-alone version (which is fine, just want to know how).
Ideally we can transition the current bash health check script into using this, so we only have (as much as is possible) a single place that gathers the data we want.

That's why we ended up with the sled-diagnostics crate which would allow you to call whatever you would like outside of support bundle gathering. The crate could include a binary if that would be helpful that could expose common things such as the health check commands.

Perfect. I don't think we need to hold this PR for that though, and perhaps I can do the work for this myself :)

How does the health check script make it onto a sled today?

It's copied over manually. Someday it would be nice if we did not need to do that at all and could just use the same tool to gather data and not have to update two copies.

There may always be one off things we need to do, or updates that the new software has that the old does not, but we can at least try to have a single source for some of this :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Bundle: Include health checks
3 participants