-
Notifications
You must be signed in to change notification settings - Fork 43
[support bundle] Add health checks to support bundles #8102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Is there a way we could run these health checks outside of the support bundle gathering? Ideally we can transition the current bash health check script into using this, so we only have |
That's why we ended up with the sled-diagnostics crate which would allow you to call whatever you would like outside of support bundle gathering. The crate could include a binary if that would be helpful that could expose common things such as the health check commands. How does the health check script make it onto a sled today? |
Perfect. I don't think we need to hold this PR for that though, and perhaps I can do the work for this myself :)
It's copied over manually. Someday it would be nice if we did not need to do that at all and could just use the same tool to gather data and not have to update two copies. There may always be one off things we need to do, or updates that the new software has that the old does not, but we can at least try to have a single source for some of this :) |
Mostly fixes #8073
Does not completely cover the existing health check, but covers most of the cases