[6/n] [sled-agent] add remove_mupdate_override to OmicronSledConfig and friends #8097
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created using spr 1.3.6-beta.1
sunshowers
changed the title
Created using spr 1.3.6-beta.1
Created using spr 1.3.6-beta.1
Created using spr 1.3.6-beta.1
sunshowers
commented
May 13, 2025
Comment on lines
+333
to
+372
| #[derive(Debug, Args)] | ||
| struct SledSetPolicyArgs { | ||
| /// id of the sled | ||
| sled_id: SledUuid, | ||
|
|
||
| /// The policy to set for the sled | ||
| #[clap(value_enum)] | ||
| policy: SledPolicyOpt, | ||
| } | ||
|
|
||
| #[derive(Clone, Copy, Debug, ValueEnum)] | ||
| enum SledPolicyOpt { | ||
| InService, | ||
| NonProvisionable, | ||
| Expunged, | ||
| } | ||
|
|
||
| impl fmt::Display for SledPolicyOpt { | ||
| fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result { | ||
| match self { | ||
| SledPolicyOpt::InService => write!(f, "in-service"), | ||
| SledPolicyOpt::NonProvisionable => write!(f, "non-provisionable"), | ||
| SledPolicyOpt::Expunged => write!(f, "expunged"), | ||
| } | ||
| } | ||
| } | ||
|
|
||
| impl From<SledPolicyOpt> for SledPolicy { | ||
| fn from(value: SledPolicyOpt) -> Self { | ||
| match value { | ||
| SledPolicyOpt::InService => SledPolicy::InService { | ||
| provision_policy: SledProvisionPolicy::Provisionable, | ||
| }, | ||
| SledPolicyOpt::NonProvisionable => SledPolicy::InService { | ||
| provision_policy: SledProvisionPolicy::NonProvisionable, | ||
| }, | ||
| SledPolicyOpt::Expunged => SledPolicy::Expunged, | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
I wrote this but honestly didn't end up needing it -- left it in here because it seems somewhat useful.
sunshowers
commented
May 13, 2025
Comment on lines
+2
to
+16
| > # Load example system with 7 sleds: | ||
| > # | ||
| > # sled 0: unset -> unset (unchanged) | ||
| > # sled 1: unset -> set | ||
| > # sled 2: set -> unset | ||
| > # sled 3: set -> set (unchanged) | ||
| > # sled 4: set -> set (changed) | ||
| > # sled 5: set -> set (unchanged) but change something else | ||
| > # sled 6: set -> sled removed | ||
| > # | ||
| > # We'll also add another sled below (new_sled_id) with | ||
| > # remove_mupdate_override set. | ||
| > # | ||
| > # We don't need any zones for this test, so disable that to keep the | ||
| > # outputs minimal. |
There was a problem hiding this comment.
#8142 makes this much easier to read.
sunshowers
commented
May 13, 2025
Comment on lines
+812
to
+813
| }, | ||
| "remove_mupdate_override": null |
There was a problem hiding this comment.
Are there backcompat considerations here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds:
In subsequent commits we'll make decisions based on this.
Depends on: