Add protections for password handling in Nexus #8093
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
them in the Nexus external API type that was only used for testing purposes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This wraps uses of user passwords in
secrecytypes that:The Nexus external API parameter type for passwords kept a local String copy of user passwords in addition to the internal password type, the former of which was used only for testing purposes. This removes that, ensuring that passwords in Nexus are always wrapped in
secrecy, but it has the unfortunate requirement now that test code needs to use slightly different parameter types than those exposed by the external Nexus API. I've tried to make it clear where that happens in code and why in the code comments, but happy to take suggestions on different approaches.