Trust Quorum: Handle prepare messages + Alarms #8062
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This builds on #8052. Node's now handle `PrepareMsg`s from coordinators. The coordinator proptest was updated to generate prepares from non-existent test only nodes and send them to the coordinator. Additionally, protocol invariant violations are now detected in a few cases and recorded to the `PersistentState`. This is for debugging and support purposes. The goal is to test the code well enough that we never actually see an alarm in production.
Instead we return them wherever they can arise. This has a couple of benefits. * Higher level code can stop accepting requests when it sees an alarm to prevent endless logging and raise an alert to Nexus. * After support resolves the issue there is not necessarily any reason to manually mutate persistent state, unless that was the cause of the alarm. This also allows more straightforward/rusty error handling. Persistent state is now only returned in success cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on #8052.
Nodes now handle
PrepareMsgs from coordinators. The coordinator proptest was updated to generate prepares from non-existent test only nodes and send them to the coordinator.Additionally, protocol invariant violations are now detected in a few cases and recorded to the
PersistentState. This is for debugging and support purposes. The goal is to test the code well enough that we never actually see an alarm in production.