[mgs] PendingMgsUpdate type to have a variant for the RoT #8054
Conversation
karencfv
changed the title
| fn precheck<'a>( | ||
| &'a self, | ||
| _log: &'a slog::Logger, | ||
| _mgs_clients: &'a mut MgsClients, | ||
| _update: &'a PendingMgsUpdate, | ||
| ) -> BoxFuture<'a, Result<PrecheckStatus, PrecheckError>> { | ||
| // TODO-K: fill in the precheck | ||
| todo!() | ||
| } | ||
|
|
||
| /// Attempts once to perform any post-update actions (e.g., reset the | ||
| /// device) | ||
| fn post_update<'a>( | ||
| &'a self, | ||
| _log: &'a slog::Logger, | ||
| _mgs_clients: &'a mut MgsClients, | ||
| _update: &'a PendingMgsUpdate, | ||
| ) -> BoxFuture<'a, Result<(), GatewayClientError>> { | ||
| // TODO-K: fill in the post_update | ||
| todo!() | ||
| } |
There was a problem hiding this comment.
These will be completed in a follow up PR (step two of #7989)
karencfv
changed the title
|
@jgallagher, @lzrd adding either of you as reviewers since Dave will be out for a bit :) |
|
You are only covering RoT Hubris here, which is fine. I assume that RoT stage0 will be in later PRs. |
|
There should be some provision for ordering of updates. Stage0, then RoT Hubris, then SP Hubris. Also the restriction that only one RoT stage0 activation is in progress in the entire rack at a time. |
There was a problem hiding this comment.
There should be some provision for ordering of updates. Stage0, then RoT Hubris, then SP Hubris. Also the restriction that only one RoT stage0 activation is in progress in the entire rack at a time.
These constraints will be in later PRs but do you need to carry any of the supporting information in these structures at this time? (probably not).
I think all of this is the responsibility of the planner; this work is about how to execute an update once the planner has decided it should happen.
|
Thanks for taking a look both! I think I've addressed all comments.
Yep! only RoT for now |
Implements the first step of updating the PendingMgsUpdate type to have a variant for the RoT. This lays out the foundation for the work in #7989