Parses clickhouse log file for discovering port number #131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closes #130 when merged |
bnaecker
force-pushed
the
dev/robust-clickhouse-port-detection
branch
2 times, most recently
from
fd13409 to
998ab05
Compare
smklein
reviewed
Jun 23, 2021
bnaecker
force-pushed
the
dev/robust-clickhouse-port-detection
branch
from
998ab05 to
a48f978
Compare
smklein
approved these changes
Jun 23, 2021
bnaecker
force-pushed
the
dev/robust-clickhouse-port-detection
branch
from
a48f978 to
82019d0
Compare
Removes port-discovery methods parsing `lsof`/`pfiles` output, and parses ClickHouse log file for the HTTP port it listens on. This is only done if the program is run with a port of 0, so the OS assigns any available port. This relies on upstream changes in ClickHouse -- and the script to download ClickHouse has updated MD5s to reflected that.
bnaecker
force-pushed
the
dev/robust-clickhouse-port-detection
branch
from
82019d0 to
d05a971
Compare
|
ClickHouse on macOS is currently broken, so I'm going to wait to merge this until that's resolved. Fix is apparently here. |
- Adds checksum files for database binaries, with MD5s for each platform - Adds this checksum file to the GitHub actions cache key, so that the cache is invalidated if the sums change, i.e., as new versions of the binaries are uploaded
bnaecker
force-pushed
the
dev/robust-clickhouse-port-detection
branch
from
8818b32 to
cb49d1f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes port-discovery methods parsing
lsof/pfilesoutput, andparses ClickHouse log file for the HTTP port it listens on. This is only
done if the program is run with a port of 0, so the OS assigns any
available port. This relies on upstream changes in ClickHouse -- and the
script to download ClickHouse has updated MD5s to reflected that.