Skip to content

Add tracing support #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Add tracing support #9

wants to merge 7 commits into from

Conversation

augustuswm
Copy link

Really liked using looker with nexus logs and wanted to use it on json formatted tracing logs.

  • Add support for different source entry types
  • Add support for reading and emitting tracing logs

gjcolombo and others added 4 commits June 2, 2023 23:43
Amend the command-line help for the `-c` command to note that the RHAI variable
`r` refers to the record under consideration.

Add a README.md that describes this in a bit more detail and has a couple of
one-liner example scripts to get readers started.
@augustuswm augustuswm requested a review from jclulow December 14, 2023 22:34
@jclulow
Copy link
Collaborator

jclulow commented Dec 15, 2023

What does it look like visually when you push some tracing entries through it?

@augustuswm
Copy link
Author

augustuswm commented Dec 15, 2023

I tried to keep it close to the way the Bunyan logs look. Notably we do not have a dedicated host field, and can have an array of spans associated with a record.

(records without spans)

22:24:57.156Z DEBG cassette_sync::sf::jobs::check_for_completed: Completed job
    job = check_for_completed
22:24:57.629Z DEBG cassette_sync::sf::jobs::reserve_pending_requests: Completed job
    job = reserve_pending_requests

(records with spans)

2023-11-03 14:25:29.887Z DEBG rfd_processor::github: Ignoring branch for RFD number that is in a final state on the default branch
    number = 13
    span[0] = Process branch
    span[0]::branch = "0013"
    span[0]::commit = "13bd24ff1c4998da7203db502501bd64fdd9142d"

Just noticed though that the span version is missing the span name. I'll need to add that.

Or as an alternate display:

2023-11-03 14:25:29.887Z DEBG rfd_processor::github: Ignoring branch for RFD number that is in a final state on the default branch
    number = 13
    span[0] = Process branch
        branch = "0013"
        commit = "13bd24ff1c4998da7203db502501bd64fdd9142d"

Not sure which is preferable. Ended up switching to the tab display to reduce some of the repeated noise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants